Archived
fix(app): 决策卡的人工验收清单也按 itemId 兜底 —— 配方发的审核卡从前一条待确认都没有
装配层从前只给 `variant` 兜底,`checklist` 没有。配方(auto-runner)发审核卡时 只递了 variant —— 那张卡于是穿着验收工单的衣服、allowCustom 也对,**清单是空的**: 回传门 `checkChatCardReply` 的 `checklistMissing` 在 checklist 缺席时**恒过**, 「确认通过」当场可按。2026-08-27 用户当面定的那道人工验收闸就此凭空没了, 而屏上还看不出来 —— 清单区是空的,不是红的。 兜在装配层这一处(不是让每个调用方自己记得):模型路径将来漏传也一并保住。 判断抽成纯函数 `decisionCardFace` / `needsStepLookup`(照本仓 engines.ts 里 createOnlyViolation 那批纯函数的成例),9 测 —— 其中三条把挑出来的清单接到 真回传门上,证明闸真的因此有牙,不只是「函数回了个数组」。 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LKMZDwMbyKzjw6Hembwvet
This commit is contained in:
@@ -0,0 +1,91 @@
|
|||||||
|
/**
|
||||||
|
* **决策卡的面孔与人工验收清单,兜底在装配层这一处**(2026-08-29 终审 C2)。
|
||||||
|
*
|
||||||
|
* 病:配方(`auto-runner`)发审核卡时只递了 `variant`,没递 `checklist` ——
|
||||||
|
* 而装配层从前只给 `variant` 兜底。于是那张卡穿着验收工单的衣服、`allowCustom` 也对,
|
||||||
|
* **一条待确认都没有**:回传门的 `checklistMissing` 在 checklist 缺席时恒过,
|
||||||
|
* 「确认通过」当场可按,2026-08-27 用户当面定的那道人工验收闸凭空没了。
|
||||||
|
* 屏上还看不出来 —— 清单区是空的,不是红的。
|
||||||
|
*/
|
||||||
|
import { describe, expect, it } from 'vitest';
|
||||||
|
import { checkChatCardReply } from '@modules/human-tool';
|
||||||
|
import { cardIdSchema } from '@contracts';
|
||||||
|
import type { ChatCard, ChatCardReply } from '@contracts';
|
||||||
|
import { decisionCardFace, needsStepLookup } from '../wiring/engines.ts';
|
||||||
|
|
||||||
|
const RELEASE_STEP = {
|
||||||
|
cardVariant: 'review' as const,
|
||||||
|
acceptanceChecklist: ['逐条核对差异明细', '确认推荐等级与依据一致'],
|
||||||
|
};
|
||||||
|
|
||||||
|
describe('决策卡的面孔与清单(装配层兜底)', () => {
|
||||||
|
it('调用方递了清单就用它的 —— 引擎按剧本定好递过来,兜底不抢', () => {
|
||||||
|
const face = decisionCardFace({ variant: 'review', checklist: ['我说了算'] }, RELEASE_STEP);
|
||||||
|
expect(face.checklist).toEqual(['我说了算']);
|
||||||
|
expect(face.reviewFace).toBe(true);
|
||||||
|
});
|
||||||
|
|
||||||
|
it('**配方那一路只递了 variant:清单退回剧本声明的**(C2 的正主)', () => {
|
||||||
|
const face = decisionCardFace({ variant: 'review' }, RELEASE_STEP);
|
||||||
|
expect(face.reviewFace).toBe(true);
|
||||||
|
expect(face.checklist).toEqual(RELEASE_STEP.acceptanceChecklist);
|
||||||
|
});
|
||||||
|
|
||||||
|
it('面孔也照旧退回剧本(2026-08-27 那条不许回退)', () => {
|
||||||
|
const face = decisionCardFace({}, RELEASE_STEP);
|
||||||
|
expect(face.reviewFace).toBe(true);
|
||||||
|
});
|
||||||
|
|
||||||
|
it('剧本没声明清单:就是没有 —— 不发明一条', () => {
|
||||||
|
const face = decisionCardFace({ variant: 'review' }, { cardVariant: 'review' });
|
||||||
|
expect(face.checklist).toBeUndefined();
|
||||||
|
});
|
||||||
|
|
||||||
|
it('空清单当没给:退回剧本(空数组在回传门那儿等于没有闸)', () => {
|
||||||
|
const face = decisionCardFace({ variant: 'review', checklist: [] }, RELEASE_STEP);
|
||||||
|
expect(face.checklist).toEqual(RELEASE_STEP.acceptanceChecklist);
|
||||||
|
});
|
||||||
|
|
||||||
|
it('查不查剧本:没 itemId 查不了;两样都递全了不必查', () => {
|
||||||
|
expect(needsStepLookup({})).toBe(false);
|
||||||
|
expect(needsStepLookup({ itemId: 'T_release' })).toBe(true);
|
||||||
|
expect(needsStepLookup({ itemId: 'T_release', variant: 'review' })).toBe(true);
|
||||||
|
expect(needsStepLookup({ itemId: 'T_release', variant: 'review', checklist: ['a'] })).toBe(false);
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
/**
|
||||||
|
* **闸真的因此有牙** —— 上面挑出来的清单接到回传门上,「确认通过」才拦得住。
|
||||||
|
* 没有这一条,`decisionCardFace` 的断言只证明「函数回了个数组」。
|
||||||
|
*/
|
||||||
|
describe('清单缺席 = 闸恒过(这就是 C2 的后果)', () => {
|
||||||
|
const CARD_ID = cardIdSchema.parse('11111111-1111-4111-8111-111111111111');
|
||||||
|
const card = (checklist?: ReadonlyArray<string>): ChatCard => ({
|
||||||
|
k: 'decision',
|
||||||
|
id: CARD_ID,
|
||||||
|
at: '2026-08-29T00:00:00.000Z',
|
||||||
|
ask: '差异评估结论审核',
|
||||||
|
basis: [],
|
||||||
|
variant: 'review',
|
||||||
|
allowCustom: false,
|
||||||
|
options: [{ value: 'approve', label: '确认通过' }],
|
||||||
|
...(checklist === undefined ? {} : { checklist: [...checklist] }),
|
||||||
|
});
|
||||||
|
const reply: ChatCardReply = { k: 'decision', cardId: CARD_ID, value: 'approve' };
|
||||||
|
|
||||||
|
it('没有清单:一条都没点也通得过 —— 这正是配方发的那张卡从前的样子', () => {
|
||||||
|
expect(checkChatCardReply(card(), reply)).toEqual([]);
|
||||||
|
});
|
||||||
|
|
||||||
|
it('清单兜底进来之后:一条没点就拦', () => {
|
||||||
|
const face = decisionCardFace({ variant: 'review' }, RELEASE_STEP);
|
||||||
|
const violations = checkChatCardReply(card(face.checklist), reply);
|
||||||
|
expect(violations.map((v) => v.code)).toEqual(['checklist-incomplete']);
|
||||||
|
});
|
||||||
|
|
||||||
|
it('清单点全了才放行', () => {
|
||||||
|
const face = decisionCardFace({ variant: 'review' }, RELEASE_STEP);
|
||||||
|
const violations = checkChatCardReply(card(face.checklist), { ...reply, checked: [...RELEASE_STEP.acceptanceChecklist] });
|
||||||
|
expect(violations).toEqual([]);
|
||||||
|
});
|
||||||
|
});
|
||||||
@@ -223,6 +223,37 @@ export function createOnlyViolation(
|
|||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* 决策卡的**面孔与人工验收清单**:调用方递了就用它的,没递才退回剧本声明的(按 itemId 查到的那一步)。
|
||||||
|
*
|
||||||
|
* 纯函数:剧本那一步由调用方查好递进来,这里只挑值。
|
||||||
|
*
|
||||||
|
* **清单也要这道兜底**(2026-08-29 终审 C2):从前只有 `variant` 有兜底,`checklist` 没有 ——
|
||||||
|
* 配方(`auto-runner`)发审核卡时只递了 variant,于是那张卡穿着验收工单的衣服、`allowCustom` 也对,
|
||||||
|
* **一条待确认都没有**:回传门 `checkChatCardReply` 的 `checklistMissing` 在 checklist 缺席时**恒过**,
|
||||||
|
* 「确认通过」当场可按 —— 2026-08-27 用户当面定的那道人工验收闸凭空没了,而屏上还看不出来
|
||||||
|
* (清单区是空的,不是红的)。兜在这一处而不是让每个调用方自己记得:**模型路径将来漏传也一并保住**。
|
||||||
|
*/
|
||||||
|
export function decisionCardFace(
|
||||||
|
input: { readonly variant?: 'review' | undefined; readonly checklist?: ReadonlyArray<string> | undefined },
|
||||||
|
step: { readonly cardVariant?: string | undefined; readonly acceptanceChecklist?: ReadonlyArray<string> | undefined } | undefined,
|
||||||
|
): { reviewFace: boolean; checklist: ReadonlyArray<string> | undefined } {
|
||||||
|
const reviewFace = input.variant === 'review' || step?.cardVariant === 'review';
|
||||||
|
const checklist =
|
||||||
|
input.checklist !== undefined && input.checklist.length > 0 ? input.checklist : step?.acceptanceChecklist;
|
||||||
|
return { reviewFace, checklist };
|
||||||
|
}
|
||||||
|
|
||||||
|
/** 要不要去清单里查那一步:没给 itemId 查不了;面孔与清单都递全了不必查(省一次 manifest 取数) */
|
||||||
|
export function needsStepLookup(input: {
|
||||||
|
readonly itemId?: string | undefined;
|
||||||
|
readonly variant?: 'review' | undefined;
|
||||||
|
readonly checklist?: ReadonlyArray<string> | undefined;
|
||||||
|
}): boolean {
|
||||||
|
if (input.itemId === undefined) return false;
|
||||||
|
return input.variant === undefined || input.checklist === undefined;
|
||||||
|
}
|
||||||
|
|
||||||
export function rowReadings(
|
export function rowReadings(
|
||||||
mine: Readonly<Record<string, readonly unknown[]>>,
|
mine: Readonly<Record<string, readonly unknown[]>>,
|
||||||
declared: ReadonlyArray<{ domain: string; object: string }> = [],
|
declared: ReadonlyArray<{ domain: string; object: string }> = [],
|
||||||
@@ -1400,21 +1431,29 @@ export function wireEngines(deps: EngineWiringDeps): EngineWiring {
|
|||||||
const recommended = input.options.find((o) => o.recommended === true);
|
const recommended = input.options.find((o) => o.recommended === true);
|
||||||
/*
|
/*
|
||||||
* 审核卡(剧本 cardVariant:'review'):按验收工单的样子摆,机制仍是决策卡 —— 剧本说了算,不靠模型抄。
|
* 审核卡(剧本 cardVariant:'review'):按验收工单的样子摆,机制仍是决策卡 —— 剧本说了算,不靠模型抄。
|
||||||
* 面孔**引擎按当下那一步定好递过来**(`input.variant`,2026-08-27:模型漏了 itemId,卡退成「需要你定」);
|
* 面孔与**人工验收清单**都由调用方(引擎按当下那一步)定好递过来
|
||||||
|
* (`input.variant` / `input.checklist`,2026-08-27:模型漏了 itemId,卡退成「需要你定」);
|
||||||
* 没递才退回按 itemId 查剧本。
|
* 没递才退回按 itemId 查剧本。
|
||||||
|
*
|
||||||
|
* **清单也要这道兜底**(2026-08-29 终审 C2):从前只有 `variant` 有,`checklist` 没有 ——
|
||||||
|
* 配方发的审核卡(`auto-runner` 那一路只递了 variant)于是穿着验收工单的衣服、
|
||||||
|
* `allowCustom` 也对,**一条待确认都没有**:回传门 `checklistMissing` 在 checklist 缺席时恒过,
|
||||||
|
* 「确认通过」当场可按 —— 2026-08-27 用户当面定的那道人工验收闸凭空没了,
|
||||||
|
* 而屏上还看不出来(清单区是空的,不是红的)。
|
||||||
|
* 兜在这一处而不是各调用方自己记得:**模型路径将来漏传也一并保住**。
|
||||||
*/
|
*/
|
||||||
const reviewFace =
|
const declaredStep = needsStepLookup(input)
|
||||||
input.variant === 'review' ||
|
? (await deps.registry.manifestOf((await taskContext.of(input.taskId)).activityId)).assets.businessModel.steps?.find(
|
||||||
(input.itemId !== undefined &&
|
|
||||||
(await deps.registry.manifestOf((await taskContext.of(input.taskId)).activityId)).assets.businessModel.steps?.find(
|
|
||||||
(st) => st.item === input.itemId,
|
(st) => st.item === input.itemId,
|
||||||
)?.cardVariant === 'review');
|
)
|
||||||
|
: undefined;
|
||||||
|
const { reviewFace, checklist } = decisionCardFace(input, declaredStep);
|
||||||
const issued = await deps.humanTool.issueChatCard(
|
const issued = await deps.humanTool.issueChatCard(
|
||||||
{ taskId: input.taskId, ownerId: input.ownerId, humanCallCap: input.humanCallCap },
|
{ taskId: input.taskId, ownerId: input.ownerId, humanCallCap: input.humanCallCap },
|
||||||
{
|
{
|
||||||
k: 'decision',
|
k: 'decision',
|
||||||
...(reviewFace ? { variant: 'review' as const } : {}),
|
...(reviewFace ? { variant: 'review' as const } : {}),
|
||||||
...(input.checklist === undefined || input.checklist.length === 0 ? {} : { checklist: [...input.checklist] }),
|
...(checklist === undefined || checklist.length === 0 ? {} : { checklist: [...checklist] }),
|
||||||
id: cardIdSchema.parse(ids.next()),
|
id: cardIdSchema.parse(ids.next()),
|
||||||
at: clock.now().toISOString(),
|
at: clock.now().toISOString(),
|
||||||
ask: input.ask,
|
ask: input.ask,
|
||||||
|
|||||||
Reference in New Issue
Block a user