修:点了通过却以 exhausted 收场 —— 放行落地失败是终态,不是可重试的中间态

用户实测报的:任务起起来了,点通过就卡住,测试台也看不到日志。查下来是一条真事故: **机理**(证据链完整):`land()` 抛错(草稿与正式版并发冲突)→ 异常穿到推进器 → 推进器写一行 stderr 就 break;而这一拍**已经把 runtime 落回 running、已经扣了一步预算** —— 两秒后又来一次,空转到 steps 触顶。实测:3 步的活跑了 40 步, 终态 `exhausted`,而真正的原因只在服务端 stderr 里刷屏 (`草稿与正式版并发冲突:2 处字段已被他单改动` 刷了几十行), 任务记忆、界面、trace 上一个字都没有 —— 这正是「看不到日志」。冲突检测本身**是对的**(多单并发写同一行,基线过期即冲突,不该静默覆盖); 坏的是失败处理。三处修: ① **落地失败落终态**:`land` 抛错 → 就地 `blocked` + 原因写进任务记忆(人读得到), 推进器再也不会来推它 —— 空转到预算耗尽那条路断了 ② **失败在时间轴上标红**:非放行终态的节点 span 走 `fail()` 并带原因, 不再收成一条无害的「已结束」(从前失败的单在观测面上与走完的单长得一模一样) ③ 顺带修:`listInstances` 没读回 `assignee_id`(写了不读等于没写)—— 上一提交已含实测复核(真库 + HTTP 全链):正常路径 A1 四步 released、流转到 A4(修复前是 40 步 exhausted);单测三例锁死失败路径(blocked 终态 / 只调一次 land / 不误伤正常路)。五闸全过,测试台六例端到端照旧绿。 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KeDBx2PHLavbURXB8LJJ7m
2026-07-29 03:27:43 +08:00
parent 48bc664c7e
commit d98cdddca3
6 changed files with 198 additions and 10 deletions
@@ -0,0 +1,138 @@
+/**
+ * 放行落地**失败**的收场 —— 实测抓到的一条真事故(2026-07-29)。
+ *
+ * 症状:点了通过,任务却以 `exhausted` 收场,界面上什么都看不到。
+ * 机理:`land()` 抛错(草稿与正式版并发冲突)→ 异常穿到推进器 → 推进器写一行
+ * stderr 就 break;而这一拍**已经把 runtime 落回 running、已经扣了一步预算** ——
+ * 两秒后又来一次,一直空转到 steps 触顶(实测 3 步的活跑了 40 步)。
+ * 真正的原因只在服务端 stderr 里刷屏,任务记忆、界面、trace 上一个字都没有。
+ *
+ * 定的规矩:**落地失败是终态,不是可重试的中间态** —— 就地落 `blocked`,
+ * 原因写进任务记忆(人读得到),推进器再也不会来推它。
+ */
+import { describe, expect, it } from 'vitest';
+import type { TaskId } from '@contracts';
+import type { Task } from '../contract.ts';
+import { createTaskService } from '../internal/usecase/task-service.ts';
+import type { TaskServiceDeps } from '../internal/usecase/task-service.ts';
+
+const TASK = 't-1' as TaskId;
+
+type Harness = {
+  service: ReturnType<typeof createTaskService>;
+  readonly memories: Array<{ kind: string; title: string }>;
+  readonly landCalls: number[];
+  task: Task;
+};
+
+/** 谱已走完、放行通过 —— 只在「落地这一下」上做文章 */
+function harness(land: () => Promise<never> | Promise<{ converged: boolean; emittedPorts: string[]; ledgerRowsMerged: number; facts: unknown }>): Harness {
+  const memories: Harness['memories'] = [];
+  const landCalls: number[] = [];
+  const h: Harness = { service: undefined as never, memories, landCalls, task: undefined as never };
+  h.task = {
+    id: TASK,
+    activityId: 'a-1',
+    paradigm: 'flow',
+    ownerId: 's-1' as Task['ownerId'],
+    title: '占位活动',
+    runtime: 'running',
+    envelope: { activityId: 'a-1', packageVersion: '0.7.0' },
+    data: {},
+    caps: { steps: 40, tokens: 200000, humanCalls: 2, activeMinutes: 60 },
+    used: { steps: 3, tokens: 0, activeMs: 100, humanCalls: 1 },
+    startedAt: '2026-07-29T00:00:00.000Z',
+  };
+
+  const deps: TaskServiceDeps = {
+    store: {
+      get: async () => h.task,
+      update: async (_id, patch) => {
+        h.task = { ...h.task, ...patch };
+        return h.task;
+      },
+      addConsumption: async () => h.task.used,
+      lastProgressAt: async () => new Date('2026-07-29T00:00:01.000Z'),
+      markProgress: async () => undefined,
+      listByOwner: async () => [],
+      insert: async () => undefined,
+    },
+    activities: {
+      load: async () => ({
+        paradigm: 'flow' as const,
+        caps: h.task.caps,
+        envelope: {},
+        inputSchema: {},
+        businessModel: {},
+        stallAfter: 'PT30M',
+      }),
+    },
+    schemas: { validate: () => ({ ok: true, errors: [] }) },
+    engines: {
+      // 谱走完 + 放行通过 —— 接下来就该落地
+      flow: { load: async () => undefined, advance: async () => ({ status: 'finished', released: true, selectedPorts: {} }), onEvent: async () => ({ status: 'running' }) },
+      loop: { load: async () => undefined, advance: async () => ({ status: 'running' }), onEvent: async () => ({ status: 'running' }) },
+    },
+    memory: {
+      append: async (input) => {
+        memories.push({ kind: input.kind, title: input.title });
+      },
+      hasHistory: async () => true,
+      seal: async () => undefined,
+      distill: async () => undefined,
+    },
+    landing: {
+      land: async () => {
+        landCalls.push(landCalls.length + 1);
+        return land();
+      },
+    } as TaskServiceDeps['landing'],
+    listeners: { hasArmedListener: async () => false },
+    persistence: { hasDrafts: async () => false, hasRuntimeState: async () => true },
+    events: { publishTerminal: async () => undefined, publishControl: async () => undefined },
+    notifier: { notify: async () => undefined },
+    interaction: { setPhase: async () => undefined },
+    clock: { now: () => new Date('2026-07-29T00:00:02.000Z') },
+    ids: { next: () => 'x' },
+  };
+
+  h.service = createTaskService(deps);
+  return h;
+}
+
+describe('放行落地失败 —— 是终态,不是可重试的中间态', () => {
+  it('land 抛错:落 blocked 终态,原因进任务记忆(不再空转)', async () => {
+    const h = harness(async () => {
+      throw new Error('草稿与正式版并发冲突:2 处字段已被他单改动');
+    });
+
+    const out = await h.service.tick(TASK);
+    expect(out.task.terminal, '落地失败即终态').toBe('blocked');
+    expect(String(out.task.reason)).toContain('放行落地失败');
+    expect(String(out.task.reason)).toContain('并发冲突');
+
+    // 原因要人读得到 —— 从前只写 stderr,界面上一个字都没有
+    const said = h.memories.find((m) => m.title.includes('放行落地失败'));
+    expect(said, '任务记忆里要有一条说清为什么').toBeDefined();
+    expect(said!.title).toContain('并发冲突');
+  });
+
+  it('终态之后不再被推 —— 空转到预算耗尽的那条路断了', async () => {
+    const h = harness(async () => {
+      throw new Error('落地炸了');
+    });
+
+    await h.service.tick(TASK);
+    expect(h.landCalls).toHaveLength(1);
+    // 推进器只推 runtime==='running' 的任务;落了终态就再也不会来
+    expect(h.task['runtime']).toBe('terminal');
+    expect(h.task['terminal']).toBe('blocked');
+  });
+
+  it('落地成功照旧 released —— 修的是失败那条路,别误伤正常路', async () => {
+    const h = harness(async () => ({ converged: true, emittedPorts: ['intake'], ledgerRowsMerged: 2, facts: {} }));
+    const out = await h.service.tick(TASK);
+    expect(out.task.terminal).toBe('released');
+    expect(h.memories.some((m) => m.title.includes('落地收敛'))).toBe(true);
+  });
+});