Archived
用户要的是运行时机制:新建 + 编辑,存下去就生效,旧任务走完旧版本, 新任务调用时才加载新编排。所以「草稿 → 发布」两态整套去掉。 ## 闸从「发布」挪到「保存」 `savePackage` 现在先跑闭合校验,不闭合抛 `NotClosedError`(路由 412 带报告)—— **一个字节都不落库**。存进来的每一版都能起单,所以不需要「已发布」这个标记。 `publish` 用例、路由、`publishPackage` 存储方法一并删掉。 实测:把进 A6 的边映射清空后保存 → 412,逐条点名「边 e-g3-a6 未完成载荷映射; 节点「报价议价」的必填字段未映射:rows」。 ## 保存恒新增版本号,服务端说了算 这不是可选项,是「旧任务走完旧版本」的前提:工作流按 (包id, 版本) 去读定义, 就地覆盖 v1 就等于改掉所有在途 v1 任务正在读的编排 —— 它们会中途换了规则却毫不知情。 版本号由用例层算(当前最大 + 1),**不采信入参**。实测:入参故意填 version: 999, 落的是 v2。store 层因此改成**只插不改**:撞键宁可让唯一约束报错,也不静默覆盖。 起单取版从「最新已发布」改为「最新一版」(retired 除外);触发器的 requiredInputs 同口径。 实测:改完描述存成 v2 后,新起的单用 v2,早先那单仍挂 v1。 ## 迁移:旧状态值不归一就是一读就炸 状态枚举从 draft/published/retired 收成 active/retired。列上和 definition 这个 jsonb 里 各存着一份 state,两处都要改 —— 不改,`processPackageSchema.parse` 读一行就抛。 这不是开发期小麻烦,任何已部署实例都会中招。加了迁移 0012。 ## 界面:恒为 0 的假指标撤掉,不换个说法留着 - 编排面板:「已发布/草稿」芯片 → 「生效中/历史版本」(真正的区别是哪一版会被新起单取到); 发布按钮撤掉,保存按钮改成「保存并生效(存为 vN)」并在确认卡里说清影响面 - 历史版本只读,但就地指路:「去 v(N-1) 改(生效中)」,不让人自己找 - 蓝图面:「草稿 N · 未闭合 M」两个计数在新机制下**结构上恒为 0**(不闭合存不进来), 换成「共 N 个版本,保存即生效」 - 驾驶舱:「未闭合草稿」卡整张撤掉 —— 同理恒为 0。天然的第三张是「死路」 (route-dead-end 事件),但那需要一条按事件类型聚合的路由,没有之前不摆(同死信卡的规矩) ## 顺手修:种子的幂等判断本来是坏的 比对用 `JSON.stringify` 认键序,而 jsonb 从 PG 读回来键是重排过的 —— 永远判不等, 每播一次种就多存一版一模一样的定义(实测一口气堆到 v3)。改成递归按键名排序后比对。 连播三次,只第一次存。 ## 契约变更(破坏性,一步到位) `publish` 删除、`NotPublishableError` → `NotClosedError`、`publishable` → `closed`、 状态枚举收窄。按规矩破坏性变更该走三步弃用 —— 这里一步改完,因为: ① depcruise 反查下游全在仓内(374 模块无违规),同批改完; ② 要弃用的是一个**产品决定不再存在**的机制,留弃用窗口没有意义。 CONTRACT.md 已同步,快照单独说明。 typecheck ✓ lint ✓ depcruise 374 模块 ✓ 495 测试 ✓ Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KeDBx2PHLavbURXB8LJJ7m
163 lines
6.2 KiB
TypeScript
163 lines
6.2 KiB
TypeScript
/**
|
|
* process 存储 adapter —— Drizzle 只准出现在 adapter(编码规范 §5.3)。
|
|
*/
|
|
import { and, asc, desc, eq } from 'drizzle-orm';
|
|
import type { ProcessPackage, TerminalState, WorkflowState } from '@contracts';
|
|
import { processPackageSchema } from '@contracts';
|
|
import type { Db } from '@shared/db.ts';
|
|
import type { ProcessStore, WorkflowRecord } from '../../port.ts';
|
|
import type { NodeInstance } from '../domain/owner-resolution.ts';
|
|
import { nodeInstanceTable, processPackageTable, workflowTable } from './process-schema.ts';
|
|
|
|
type WorkflowRow = typeof workflowTable.$inferSelect;
|
|
|
|
function toWorkflow(row: WorkflowRow): WorkflowRecord {
|
|
return {
|
|
id: row.id,
|
|
packageId: row.packageId,
|
|
packageVersion: row.packageVersion,
|
|
subject: row.subject,
|
|
state: row.state as WorkflowState,
|
|
source: row.source as WorkflowRecord['source'],
|
|
initiation: row.initiation as Record<string, unknown>,
|
|
...(row.workGroup === null ? {} : { workGroup: row.workGroup as Record<string, string> }),
|
|
ports: row.ports as Record<string, Record<string, unknown>>,
|
|
vars: row.vars as Record<string, unknown>,
|
|
startedAt: row.startedAt.toISOString(),
|
|
...(row.finishedAt === null ? {} : { finishedAt: row.finishedAt.toISOString() }),
|
|
};
|
|
}
|
|
|
|
export function createProcessStore(db: Db): ProcessStore {
|
|
return {
|
|
/*
|
|
* **只插不改**:版本一旦落库就是不可变的历史。
|
|
* 版本号由用例层算(恒新增),所以这里不该撞键;真撞了就让唯一约束报出来 ——
|
|
* 静默覆盖会改掉在途任务正在读的定义,那是最不该无声发生的事。
|
|
*/
|
|
async savePackage(pkg: ProcessPackage) {
|
|
await db
|
|
.insert(processPackageTable)
|
|
.values({ id: pkg.id, version: pkg.version, name: pkg.name, state: pkg.state, definition: pkg });
|
|
},
|
|
|
|
async getPackage(id, version) {
|
|
const conditions = [eq(processPackageTable.id, id)];
|
|
if (version !== undefined) conditions.push(eq(processPackageTable.version, version));
|
|
const rows = await db
|
|
.select()
|
|
.from(processPackageTable)
|
|
.where(and(...conditions))
|
|
.orderBy(desc(processPackageTable.version))
|
|
.limit(1);
|
|
return rows[0] === undefined ? undefined : processPackageSchema.parse(rows[0].definition);
|
|
},
|
|
|
|
async listPackages() {
|
|
const rows = await db.select().from(processPackageTable).orderBy(asc(processPackageTable.name));
|
|
return rows.map((r) => processPackageSchema.parse(r.definition));
|
|
},
|
|
|
|
async insertWorkflow(record) {
|
|
await db.insert(workflowTable).values({
|
|
id: record.id,
|
|
packageId: record.packageId,
|
|
packageVersion: record.packageVersion,
|
|
subject: record.subject,
|
|
state: record.state,
|
|
source: record.source,
|
|
initiation: record.initiation,
|
|
workGroup: record.workGroup ?? null,
|
|
ports: record.ports,
|
|
vars: record.vars,
|
|
startedAt: new Date(record.startedAt),
|
|
});
|
|
},
|
|
|
|
async getWorkflow(id) {
|
|
const rows = await db.select().from(workflowTable).where(eq(workflowTable.id, id)).limit(1);
|
|
return rows[0] === undefined ? undefined : toWorkflow(rows[0]);
|
|
},
|
|
|
|
async listWorkflows(limit) {
|
|
const rows = await db.select().from(workflowTable).orderBy(desc(workflowTable.startedAt)).limit(limit);
|
|
return rows.map(toWorkflow);
|
|
},
|
|
|
|
async updateWorkflow(id, patch) {
|
|
const values: Record<string, unknown> = {};
|
|
if (patch.state !== undefined) values['state'] = patch.state;
|
|
if (patch.ports !== undefined) values['ports'] = patch.ports;
|
|
if (patch.vars !== undefined) values['vars'] = patch.vars;
|
|
if (patch.finishedAt !== undefined) values['finishedAt'] = new Date(patch.finishedAt);
|
|
const [row] = await db.update(workflowTable).set(values).where(eq(workflowTable.id, id)).returning();
|
|
if (row === undefined) throw new Error(`工作流不存在:${id}`);
|
|
return toWorkflow(row);
|
|
},
|
|
|
|
async listInstances(workflowId) {
|
|
const rows = await db
|
|
.select()
|
|
.from(nodeInstanceTable)
|
|
.where(eq(nodeInstanceTable.workflowId, workflowId))
|
|
.orderBy(asc(nodeInstanceTable.createdAt));
|
|
return rows.map(
|
|
(r): NodeInstance => ({
|
|
nodeId: r.nodeId,
|
|
instance: r.instance,
|
|
running: r.running,
|
|
waiting: r.waiting,
|
|
activated: r.activated,
|
|
...(r.terminal === null ? {} : { terminal: r.terminal as TerminalState }),
|
|
...(r.failureDigested === null ? {} : { failureDigested: r.failureDigested }),
|
|
}),
|
|
);
|
|
},
|
|
|
|
async insertInstance(workflowId, instance) {
|
|
await db.insert(nodeInstanceTable).values({
|
|
workflowId,
|
|
nodeId: instance.nodeId,
|
|
instance: instance.instance,
|
|
running: instance.running,
|
|
waiting: instance.waiting,
|
|
activated: instance.activated,
|
|
terminal: instance.terminal ?? null,
|
|
failureDigested: instance.failureDigested ?? null,
|
|
taskId: instance.taskId ?? null,
|
|
approvalId: instance.approvalId ?? null,
|
|
});
|
|
},
|
|
|
|
async updateInstance(workflowId, nodeId, instance, patch) {
|
|
const values: Record<string, unknown> = {};
|
|
if (patch.running !== undefined) values['running'] = patch.running;
|
|
if (patch.waiting !== undefined) values['waiting'] = patch.waiting;
|
|
if (patch.terminal !== undefined) values['terminal'] = patch.terminal;
|
|
if (patch.failureDigested !== undefined) values['failureDigested'] = patch.failureDigested;
|
|
if (patch.taskId !== undefined) values['taskId'] = patch.taskId;
|
|
if (Object.keys(values).length === 0) return;
|
|
await db
|
|
.update(nodeInstanceTable)
|
|
.set(values)
|
|
.where(
|
|
and(
|
|
eq(nodeInstanceTable.workflowId, workflowId),
|
|
eq(nodeInstanceTable.nodeId, nodeId),
|
|
eq(nodeInstanceTable.instance, instance),
|
|
),
|
|
);
|
|
},
|
|
|
|
async findInstanceByTask(taskId) {
|
|
const rows = await db
|
|
.select()
|
|
.from(nodeInstanceTable)
|
|
.where(eq(nodeInstanceTable.taskId, taskId))
|
|
.limit(1);
|
|
const row = rows[0];
|
|
return row === undefined ? undefined : { workflowId: row.workflowId, nodeId: row.nodeId, instance: row.instance };
|
|
},
|
|
};
|
|
}
|